self code review

belav · Mar 1, 2024 · c374fab · c374fab
1 parent 0571298
commit c374fab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Src/CSharpier.Rider/gradle.properties b/Src/CSharpier.Rider/gradle.properties
@@ -3,7 +3,7 @@
 
 pluginGroup = com.intellij.csharpier
 pluginName = csharpier
-pluginVersion = 1.6.1
+pluginVersion = 1.6.1-beta
 
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.

diff --git a/Src/CSharpier.Rider/src/main/java/com/intellij/csharpier/CSharpierProcessProvider.java b/Src/CSharpier.Rider/src/main/java/com/intellij/csharpier/CSharpierProcessProvider.java
@@ -65,6 +65,7 @@ public void documentChanged(@NotNull DocumentEvent event) {
     }
 
     private void findAndWarmProcess(String filePath) {
+        // if we didn't find dotnet bail out so we don't get extra errors about being unable to format
         if (!DotNetProvider.getInstance(this.project).foundDotNet()) {
             return;
         }
@@ -94,6 +95,7 @@ private void findAndWarmProcess(String filePath) {
     }
 
     public ICSharpierProcess getProcessFor(String filePath) {
+        // if we didn't find dotnet bail out so we don't get extra errors about being unable to format
         if (!DotNetProvider.getInstance(this.project).foundDotNet()) {
             return NullCSharpierProcess.Instance;
         }

diff --git a/Src/CSharpier.Rider/src/main/java/com/intellij/csharpier/DotNetFinder.java b/Src/CSharpier.Rider/src/main/java/com/intellij/csharpier/DotNetFinder.java
@@ -27,7 +27,7 @@ public static String findOnPath(Logger logger) {
 
         String version = null;
 
-        String[] lines = dotnetInfo.split("\\r?\\n");
+        var lines = dotnetInfo.split("\\r?\\n");
         for (var line : lines) {
             var pattern = Pattern.compile("^\\s*Version:\\s*([^\\s].*)$");
             var matcher = pattern.matcher(line);