feat: reuse collection types for DocFitter
#1491
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new instance of
StringBuilder
andStack<PrintCommand>
every timeDocFitter.Fit
is called we instead create a single instance of each inDocPrinter
and pass it intoDocFitter.Fit
.This could be replaced by using
ValueStringBuilder
andValueListBuilder
, the latter would be beneficial as unlikeStack<T>
we can access items by index instead of theO(n)
lookup time withElementAt
.Before
After