Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22-search-grid-generator-grid-added #26

Conversation

LaraBaseggio
Copy link

🚀 Pull Request
Description
🔍 Regarding Issue #22, working on transforming the existing map grid into an alphanumeric format. As a first step, we've added a transparent overlay with a grid and a center point to help users easily identify specific areas on the map.

Type of Change
Please check the relevant options:

  • 🐛 Bug fix (non-breaking change)
  • ✨ New feature (non-breaking change)
  • ⚠️ Breaking change
  • [x ] 📚 Documentation update

This activity is supported by the Network Institute under the Code for Humanity initiative.

@GalenReich
Copy link
Contributor

GalenReich commented Nov 13, 2024

Hi @LaraBaseggio, thank you for opening this PR and thank you for sharing a video showing what your changes do on your local machine.

At the moment this PR is in the open source research notebooks repository, but the video shows changes to the search grid generator repository. For your understanding, the notebooks repository contains Jupyter/Colab notebooks that let people access tools that we don't develop further. The search grid repository contains the vue project for the web app version of the search grid tool.

As it looks like you have made changes to the vue project, it is probably more appropriate to open a PR on that repository.

A few tips for PRs generally:

  • Review the changes you are committing - by double checking the code you are committing you can spot when changes include debugging comments or (in this case) cell output.
  • Add files and folders associated with your editor to the .gitignore file (in this case .idea and inspectionProfiles folders) - this helps keep PRs clean and avoid polluting the repository with developer-specific files.
  • Don't be afraid to ask questions if you are uncertain why code is structured in a particular way - in the notebook, we deliberately place all code in a single cell to provide a simpler interface for the end user, who may be non-technical. See the notebook on Colab to see what this looks like. Breaking the code into separate cells reduces the usability for people with limited technical experience.

If you plan on working in this notebooks repository, please convert this PR to draft.

If you'd like to open a PR on the Vue web app then I would suggest closing this PR and opening a fresh one in that repository.

I hope this helps! And I wish you all the best with your development! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants