Make more classes readonly that Rector missed (#172)

ben-challis · Sep 1, 2023 · 318547f · 318547f
1 parent 39754aa
commit 318547f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/src/ClassDiscovery/DelegateClassDiscoverer.php b/src/ClassDiscovery/DelegateClassDiscoverer.php
@@ -4,12 +4,12 @@
 
 namespace BenChallis\SqlMigrations\ClassDiscovery;
 
-final class DelegateClassDiscoverer implements ClassDiscoverer
+final readonly class DelegateClassDiscoverer implements ClassDiscoverer
 {
     /**
      * @var list<ClassDiscoverer>
      */
-    private readonly array $discoverers;
+    private array $discoverers;
 
     public function __construct(ClassDiscoverer ...$discoverers)
     {

diff --git a/src/ClassDiscovery/Psr4/Psr4NamespacePrefixClassDiscoverer.php b/src/ClassDiscovery/Psr4/Psr4NamespacePrefixClassDiscoverer.php
@@ -10,14 +10,14 @@
 use BenChallis\SqlMigrations\ClassDiscovery\ReadableDirectory;
 use Symfony\Component\Finder\Finder;
 
-final class Psr4NamespacePrefixClassDiscoverer implements ClassDiscoverer
+final readonly class Psr4NamespacePrefixClassDiscoverer implements ClassDiscoverer
 {
     /**
      * @var list<ReadableDirectory>
      */
-    private readonly array $directories;
+    private array $directories;
 
-    public function __construct(private readonly PhpNamespace $namespacePrefix, ReadableDirectory ...$directories)
+    public function __construct(private PhpNamespace $namespacePrefix, ReadableDirectory ...$directories)
     {
         $this->directories = \array_values($directories);
     }

diff --git a/src/ClassDiscovery/ReadableDirectory.php b/src/ClassDiscovery/ReadableDirectory.php
@@ -4,9 +4,9 @@
 
 namespace BenChallis\SqlMigrations\ClassDiscovery;
 
-final class ReadableDirectory
+final readonly class ReadableDirectory
 {
-    private readonly string $directory;
+    private string $directory;
 
     private function __construct(string $directory)
     {

diff --git a/src/ClassDiscovery/ReadableFile.php b/src/ClassDiscovery/ReadableFile.php
@@ -4,9 +4,9 @@
 
 namespace BenChallis\SqlMigrations\ClassDiscovery;
 
-final class ReadableFile
+final readonly class ReadableFile
 {
-    private readonly string $filePath;
+    private string $filePath;
 
     private function __construct(string $filePath)
     {

diff --git a/src/Migration/InMemoryMigrations.php b/src/Migration/InMemoryMigrations.php
@@ -14,12 +14,12 @@
 /**
  * In-memory state of migrations, requiring data upfront.
  */
-final class InMemoryMigrations implements Migrations
+final readonly class InMemoryMigrations implements Migrations
 {
     /**
      * @var MutableMap<int, Migration>
      */
-    private readonly MutableMap $map;
+    private MutableMap $map;
 
     /**
      * @param MapInterface<int, Migration> $map