Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more classes readonly that Rector missed #172

Merged
merged 1 commit into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ClassDiscovery/DelegateClassDiscoverer.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

namespace BenChallis\SqlMigrations\ClassDiscovery;

final class DelegateClassDiscoverer implements ClassDiscoverer
final readonly class DelegateClassDiscoverer implements ClassDiscoverer
{
/**
* @var list<ClassDiscoverer>
*/
private readonly array $discoverers;
private array $discoverers;

public function __construct(ClassDiscoverer ...$discoverers)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
use BenChallis\SqlMigrations\ClassDiscovery\ReadableDirectory;
use Symfony\Component\Finder\Finder;

final class Psr4NamespacePrefixClassDiscoverer implements ClassDiscoverer
final readonly class Psr4NamespacePrefixClassDiscoverer implements ClassDiscoverer
{
/**
* @var list<ReadableDirectory>
*/
private readonly array $directories;
private array $directories;

public function __construct(private readonly PhpNamespace $namespacePrefix, ReadableDirectory ...$directories)
public function __construct(private PhpNamespace $namespacePrefix, ReadableDirectory ...$directories)
{
$this->directories = \array_values($directories);
}
Expand Down
4 changes: 2 additions & 2 deletions src/ClassDiscovery/ReadableDirectory.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace BenChallis\SqlMigrations\ClassDiscovery;

final class ReadableDirectory
final readonly class ReadableDirectory
{
private readonly string $directory;
private string $directory;

private function __construct(string $directory)
{
Expand Down
4 changes: 2 additions & 2 deletions src/ClassDiscovery/ReadableFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace BenChallis\SqlMigrations\ClassDiscovery;

final class ReadableFile
final readonly class ReadableFile
{
private readonly string $filePath;
private string $filePath;

private function __construct(string $filePath)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Migration/InMemoryMigrations.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
/**
* In-memory state of migrations, requiring data upfront.
*/
final class InMemoryMigrations implements Migrations
final readonly class InMemoryMigrations implements Migrations
{
/**
* @var MutableMap<int, Migration>
*/
private readonly MutableMap $map;
private MutableMap $map;

/**
* @param MapInterface<int, Migration> $map
Expand Down