Skip to content

Conversation

@kimmellr
Copy link

@kimmellr kimmellr commented Oct 1, 2016

No description provided.

@ben519
Copy link
Owner

ben519 commented Oct 1, 2016

Thank for the attempt, but I see many issues with your code. For example line 206 uses .nunique() which is different more expensive than something like .count(). Many things depend on line 205 and many things don't sync well with the data.table examples. Also, you've only updated one file but there are multiple files that need to be updated. Thanks for trying though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants