Skip to content

Commit

Permalink
fix appearance broken by reflex-dev#3812 (reflex-dev#4403)
Browse files Browse the repository at this point in the history
* fix appearance broken by reflex-dev#3812

* fix again to pass tests
  • Loading branch information
Lendemor authored Nov 20, 2024
1 parent 229df1c commit 681b616
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions reflex/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -850,8 +850,6 @@ def get_compilation_time() -> str:
if self.theme is not None:
# If a theme component was provided, wrap the app with it
app_wrappers[(20, "Theme")] = self.theme
# Fix #2992 by removing the top-level appearance prop
self.theme.appearance = None

for route in self.unevaluated_pages:
console.debug(f"Evaluating page: {route}")
Expand Down Expand Up @@ -1007,6 +1005,9 @@ def _submit_work(fn, *args, **kwargs):
compile_results.append(
compiler.compile_contexts(self.state, self.theme),
)
if self.theme is not None:
# Fix #2992 by removing the top-level appearance prop
self.theme.appearance = None
progress.advance(task)

# Compile the app root.
Expand Down

0 comments on commit 681b616

Please sign in to comment.