Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

use gunicorn server instead of django test server (as recommended by taiga) #35 #42 #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anddann
Copy link

@anddann anddann commented Feb 9, 2018

This pull request fixes #35, fixes #42 and contains the following changes:

@anddann anddann changed the title use gunicorn server instead of djanga test server (as recommended by taiga) use gunicorn server instead of django test server (as recommended by taiga) Feb 9, 2018
@anddann anddann changed the title use gunicorn server instead of django test server (as recommended by taiga) use gunicorn server instead of django test server (as recommended by taiga) #35 Feb 9, 2018
@anddann anddann changed the title use gunicorn server instead of django test server (as recommended by taiga) #35 use gunicorn server instead of django test server (as recommended by taiga) #35 #42 Feb 9, 2018
@lifenautjoe
Copy link

@benhutchins could you please take a look? 🙏

@benhutchins
Copy link
Owner

I really like this idea, just need to test this. Thank you for the contribution @anddann. I'll set some time aside to test this and, assuming it works, I'll merge it.

Copy link

@ajira86 ajira86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild a docker image and launch it. Works like a charm.
Additionally locale-gen is a better approach to setup locales.

@anddann
Copy link
Author

anddann commented May 27, 2018

I guess all files in conf needs to be updated not only conf/nginx.conf with the new port number 8001

@ajira86
Copy link

ajira86 commented May 28, 2018

Is there a reason to change 8000 port for 8001 ?

@anddann
Copy link
Author

anddann commented May 28, 2018

No, there is no particular reason. I just did it because it is the default in the django documentation.

@ajira86
Copy link

ajira86 commented May 28, 2018

The 8000 port is the default for the test server, we can continue to keep this one. I'm still preparing an upgrade for Taiga in version 3.3.2 which will take care of database migration. I will inform you if this still works with port 8000 configured but I don't use taiga-event at this time.

@ajira86 ajira86 mentioned this pull request May 28, 2018
@anddann
Copy link
Author

anddann commented Jun 4, 2018

To make things easier, I propose to migrate back to port 8000 instead of 8001.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no valid OpenPGP data found Container uses Django development webserver
4 participants