Hamming dist join #110
Merged
Hamming dist join #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+177
to
+179
| #' @param n_bands The number of LSH bands used in hashing. | ||
| #' | ||
| #' @param band_width The number of hashes in each band. |
There was a problem hiding this comment.
If those have the same definition as in other functions you can use @inheritParams jaccard_left_join for example
| clean=clean) | ||
| } | ||
|
|
||
| #' Fuzzy anti-join using minihashing |
There was a problem hiding this comment.
You can use the same @rdname tag as in the other join functions to simplify the docs and gather those functions them in a single page
Comment on lines
+27
to
+28
| a_col <- gsub("[[:punct:] ]", "", dplyr::pull(a, by_a)) | ||
| b_col <- gsub("[[:punct:] ]", "", dplyr::pull(b, by_b)) |
There was a problem hiding this comment.
Suggested change
| a_col <- gsub("[[:punct:] ]", "", dplyr::pull(a, by_a)) | |
| b_col <- gsub("[[:punct:] ]", "", dplyr::pull(b, by_b)) | |
| a_col <- tolower(gsub("[[:punct:] ]", "", dplyr::pull(a, by_a))) | |
| b_col <- tolower(gsub("[[:punct:] ]", "", dplyr::pull(b, by_b))) |
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
|
Note that you will need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds joining method for the hamming distance. Specifically, it adds the following functions:
It also adds the
hamming_probabilityandhamming_distancefunctions to help users set the right parameters when tuning the LSH joining methods. I have tried my best to integrate the new changes (usingcollapse::%!iin%and early returns in thehamming_join_corefunction).