Score popup #177
Open
Score popup #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 10, 2024 09:45
Popup function is copied from board::popup. Maybe this should improved.
Contributor
Author
|
Evaluation info on popup (like lichess) added. |
added 4 commits
April 14, 2024 09:32
board::popup extend with an optional textline above the board
benini
force-pushed
the
github
branch
2 times, most recently
from
f96d38b to
404bda3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adresses issue #95
Additional:
The coordinates and text are not readable in the score graph because background is used from theme and others is set fix.
Now the canvas colors are applied from theme and used.
Later options:
Maybe the text (playernames and date) should be moved to the window title?
This solution could also applied on rating graph.