Refactor htext display #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
January 4, 2025 18:04
option is handled in pgn
benini
force-pushed
the
github
branch
2 times, most recently
from
f96d38b to
404bda3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a completely revised version of the htext::display procedure.
All tag-specific elements have been separated out into their own functions.
htext::display is structured as a dispatcher that calls these functions.
I hope that this has significantly reduced the complexity.
I have also added two new functions:
Display of a diagram for NAG D https://sourceforge.net/p/scid/feature-requests/107/
Expanding and collapsing the variants https://sourceforge.net/p/scid/feature-requests/126/
The variants can be folded in and out individually.
All variants can be expanded and collapsed at the same time via popup menu
Both Functions can be set in the Display menu of the pgn window.
When adding the two functionalities, I still saw many optimizations, which is why the branch has become so large.
If the branch is too big, I can create a branch that only contains the optimization of htext::display
The graphic shows an example of the new functions.