[BUGFIX] Remove outdated language settings causing empty links#1494
Merged
benjaminkott merged 2 commits intobenjaminkott:masterfrom Oct 8, 2024
Merged
[BUGFIX] Remove outdated language settings causing empty links#1494benjaminkott merged 2 commits intobenjaminkott:masterfrom
benjaminkott merged 2 commits intobenjaminkott:masterfrom
Conversation
Since TYPO3 9.5 language settings are handled by the site config. The linkVars setting causes hard to find bugs where all links on a page are empty, see: https://forge.typo3.org/issues/104344 https://talk.typo3.org/t/empty-href-on-arbitary-pages/5737 Resolves: benjaminkott#1165
Contributor
Author
|
phpstan errors are unrelated and have been broken since before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since TYPO3 9.5 language settings are handled by the site config.
The linkVars setting causes hard to find bugs where all links on a page are empty, see:
https://forge.typo3.org/issues/104344
https://talk.typo3.org/t/empty-href-on-arbitary-pages/5737
Resolves: #1165
Pull Request
Related Issues
Prerequisites
php-cs-fixer fixcd Build; npm ci; npm run build)Description
[Description of changes proposed in this pull request]
Steps to Validate
See Issue