Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasattr function #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

NotAFile
Copy link

The hasattr() function on python2 is famously dangerous and a frequent
source of problems. This backports the slighly less dangerous Python 3 version
to Python2.

The hasattr() function on python2 is famously dangerous and a frequent
source of problems. This backports the slighly less dangerous Python 3 version
to Python2.
@graingert
Copy link
Contributor

@benjaminp can you review this pr?

"""Return whether the object has an attribute with the given name.

This is done by calling getattr(obj, name) and catching AttributeError."""
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

        try:
            getattr(obj, attr_name)
        except AttributeError:
            return False
        return True

is a bit nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants