Add deep select: Cmd+hover to pierce through overlays and wrappers#119
Open
stevysmith wants to merge 2 commits intobenjitaylor:mainfrom
Open
Add deep select: Cmd+hover to pierce through overlays and wrappers#119stevysmith wants to merge 2 commits intobenjitaylor:mainfrom
stevysmith wants to merge 2 commits intobenjitaylor:mainfrom
Conversation
|
@stevysmith is attempting to deploy a commit to the Benji Taylor's Projects Team on Vercel. A member of the Team first needs to authorize it. |
Hold Cmd (Mac) / Ctrl (Win) while hovering to scan through invisible overlays, empty container wrappers, and opacity:0 animation ghosts to select the actual content underneath. Two-pass pierce algorithm: 1. Find elements with direct text content (skips empty wrappers) 2. Smallest visible element fallback (catches visual-only elements) Also improves element identification: direct text content is now checked before class names, so "$54" shows instead of "styles.price". Visual indicators: dashed highlight border and "⇣ deep select" label in the hover tooltip when pierce mode is active. Adds animated demo to the features page with keyboard shortcut entry.
stevysmith
force-pushed
the
feat/deep-select
branch
from
40a3d66 to
e41acf1
Compare
alexgorbatchev
added a commit
to alexgorbatchev/agentation
that referenced
this pull request
Mar 10, 2026
…ce overlays) Cherry-pick of benjitaylor#119 by stevysmith. Adds Cmd+hover to pierce through overlays, empty wrappers, and opacity:0 elements.
alexgorbatchev
added a commit
to alexgorbatchev/agentation
that referenced
this pull request
Mar 10, 2026
…ce overlays) Cherry-pick of benjitaylor#119 by stevysmith. Adds Cmd+hover to pierce through overlays, empty wrappers, and opacity:0 elements.
3 tasks
alexgorbatchev
added a commit
to alexgorbatchev/agentation
that referenced
this pull request
Mar 10, 2026
Merge upstream PR benjitaylor#119: deep select (Cmd+hover)
alexgorbatchev
added a commit
to alexgorbatchev/agentation
that referenced
this pull request
Mar 10, 2026
- deep-select.test.tsx: 13 tests for pierce mode behavior - element-identification.test.ts: 9 tests for direct text content - react-detection.test.ts: tests for Remotion/RefForwarding skip patterns - Add test script to package.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…gn demo - Fix delay: add keydown/keyup listeners so pressing Cmd instantly re-evaluates hover without requiring mouse movement - Same element: when pierce finds same element as normal hover, suppress pierce indicator (solid border stays) - Remove arrow label: delete "⇣ deep select" text and hoverPierceIndicator CSS — dashed outline is sufficient - Redesign demo: replace inbox scenario with landing page hero + motion.div wrapper, gradient CTA, social proof, entrance animation - Add dual cursor (crosshair/pointer) and human-like popup interaction - Add <motion.div> label hint on wrapper boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hold Cmd (Mac) / Ctrl (Win) while hovering to scan through invisible overlays, empty container wrappers, and opacity:0 animation ghosts to select the actual content underneath.
How it works
Two-pass pierce algorithm:
Also improves element identification: direct text content is now checked before class names, so "$54" shows instead of "styles.price".
Visual indicators
Instant response
Pressing Cmd/Ctrl instantly re-evaluates the hover target via keydown/keyup listeners — no mouse movement required. Previously only mousemove triggered evaluation, causing a perceived delay.
Feature demo
Animated demo on the features page showing a landing page hero wrapped in a motion.div animation container:
Keyboard shortcut entry added to the shortcuts table.