Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,23 @@ The tool expects your settings in settings.json. Take a look at settings.example
- `npm testLocal` To run all the unit tests, with the integrations, which require you to set all api keys in settings.json.

## Contributing
Please send PR's to the develop branch!
1. Fork it!
2. Create your feature branch: `git checkout -b my-new-feature`
3. Commit your changes: `git commit -am 'Add some feature'`
4. Push to the branch: `git push origin my-new-feature`
5. Submit a pull request :D
5. Submit a pull request to the develop branch :D

## Releasing
```
git checkout develop
git flow release start "1.6.2"
npm run test
npm --no-git-tag-version version 1.6.2
git flow release finish "1.6.2"
git push
git checkout master && git push && git push --tags
```

## License
See LICENSE.md
Expand Down
8 changes: 5 additions & 3 deletions src/model/integrations/BinanceWallet.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import Binance from 'binance'

export default class BinanceWallet extends AbstractWallet {
/**
* Returns the balances for a bittrex account.
* @param credential The bittrex api credentials.
* Returns the balances for a binance account.
* @param credential The binance api credentials.
* @return {Promise} The account balances.
* @prop account The accounts for given credentials.
* @prop account.balance The balance of the account.
Expand All @@ -24,7 +24,9 @@ export default class BinanceWallet extends AbstractWallet {
let symbol = data.asset
let amount = data.free

result.push(new Coin(symbol, amount, 'Binance'))
if (amount > 0) {
result.push(new Coin(symbol, amount, 'Binance'))
}
}
resolve(result)
})
Expand Down