Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variablise the Makefile for the Docker commands #237

Merged
merged 1 commit into from
Aug 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
NAME := trello-cli
DOCKER_PREFIX = benmatselby
DOCKER_RELEASE ?= latest
DOCKER_PLATFORM ?= --platform=amd64

explain:
### Welcome
#
Expand Down Expand Up @@ -61,8 +66,8 @@ test-cov: ## Run the unit tests with code coverage

.PHONY: docker-build
docker-build: ## Build the docker image
docker build -t benmatselby/trello-cli .
docker build -t $(DOCKER_PREFIX)/$(NAME) $(DOCKER_PLATFORM) .

.PHONY: docker-run
docker-run: ## Run the docker image
docker run --rm -eTRELLO_CLI_KEY -eTRELLO_CLI_SECRET benmatselby/trello-cli board:list -s
docker run --rm -eTRELLO_CLI_KEY -eTRELLO_CLI_SECRET $(DOCKER_PREFIX)/$(NAME) board:list -s