-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docs to use new runtime API #5177
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 2 total issue(s) found.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- Bento
- [Dd]istro
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, 4 total issue(s) found.
docs/source/build-with-bentoml/observability/monitoring-and-data-collection.rst
Show resolved
Hide resolved
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, 7 total issue(s) found.
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22 files reviewed, 7 total issue(s) found.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22 files reviewed, 8 total issue(s) found.
For more information, see https://pre-commit.ci
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
I think the pr is ready for review now. @frostming PTAL and I will update it if changes are needed, but please don't merge it. Thanks. |
Signed-off-by: Sherlock113 <sherlockxu07@gmail.com>
@@ -62,7 +62,7 @@ Run the service code locally (serving at http://localhost:3000 by default): | |||
```bash | |||
pip install torch transformers # additional dependencies for local run | |||
|
|||
bentoml serve service.py:Summarization | |||
bentoml serve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that service.py
is a convention, otherwise you can specify it like bentoml serve <module_name>:<attr_name>
What does this PR address?
Update the docs to use the new Python SDK for build runtime configs. This pr should be merged when the support is added to BentoCloud.
Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.