-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Homebridge v2 #198
base: master
Are you sure you want to change the base?
Compatibility with Homebridge v2 #198
Conversation
Fixed typos
I'd like someone to review please |
This is awesome. No code changea at all needed? |
Nope. But note I only tested the motion sensor. Strictly speaking, we should test every sensor type as I see you have a chunk of code per sensor. If you had some non-conformal code, it would through an error in Homebridge v2. But of course, if the code is done well, and you stick to the defined characteristic values, then no error will occur. |
Ok, I will check how I can upgrade my docker homebridge to v2. This way some more accessories will be tested. |
I've created a full config with all supported accessories. Found this small issue, I'll fix it:
Also fixed some names in the example config to be consistent with other examples |
Testing of each and ever sensor still needs to be done |
Awesome. As soon as I can update my homebridge to v2 I will test it and merge it. |
Noted one issue last night: Caused by I'll look at it tonight |
Saw a logging error and fixed it, and fixed some capitalisation errors in the logging in HttpWebHookThermostatAccessory.js, see commit log |
0.1.19-beta.1
From jsiegenthaler:
Updated package.json to show compatibility with Homebridge v2
tested on homebdrige v2 with a motion sensor, all OK
Updated dependencies:
"http-auth": "^4.2.0",
"node-persist": "^2.1.0",
"request": "^2.88.2",
"selfsigned": "^2.4.1"
NOTE: a newer version of node-persist exists but all storage commands are async , requiring more code changes