Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for int64 overflow when computing uint64 diff #2181

Closed
wants to merge 1 commit into from

Check for int64 overflow when computing uint64 diff

e83e8d8
Select commit
Loading
Failed to load commit list.
Closed

Check for int64 overflow when computing uint64 diff #2181

Check for int64 overflow when computing uint64 diff
e83e8d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 28, 2024 in 0s

26.65% (target 0.00%)

View this Pull Request on Codecov

26.65% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.65%. Comparing base (8ff5bd3) to head (e83e8d8).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ate-transition/pkg/core/state_processor_payload.go 50.00% 2 Missing and 2 partials ⚠️
mod/state-transition/pkg/core/metrics.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   26.56%   26.65%   +0.08%     
==========================================
  Files         363      363              
  Lines       16493    16520      +27     
  Branches       12       12              
==========================================
+ Hits         4382     4403      +21     
- Misses      11829    11833       +4     
- Partials      282      284       +2     
Files with missing lines Coverage Δ
mod/primitives/pkg/math/u64.go 100.00% <100.00%> (ø)
mod/state-transition/pkg/core/metrics.go 82.35% <70.00%> (-17.65%) ⬇️
...ate-transition/pkg/core/state_processor_payload.go 22.48% <50.00%> (+0.08%) ⬆️