temp #6
Closed
temp #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable CLI to work with custom block header types by requiring From<alloy_consensus::Header> conversion. This allows chains to use custom headers while maintaining CLI compatibility through standard Ethereum header conversion. Changes: - Make init_state command generic over BlockHeader types - Add From<Header> trait bound for custom headers - Update header factory to use generic conversion - Fix header field access to use trait methods
Clean up code formatting and import organization: - Fix multi-line type parameter formatting - Add missing trailing comma in where clause - Reorganize imports for better readability - Format constraint bounds consistently This addresses formatting issues from the previous commit.
The function only needs Decodable trait to read RLP-encoded headers. BlockHeader constraint was redundant since the function doesn't use any BlockHeader methods - it only decodes the header from RLP bytes.
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on paradigmxyz#17441