fix: verify result should be false if error #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isValid
value ofSdJwtVc.verify
return object would be true, if thoughcontainsRequiredVcProperties
orcontainsExpectedKeyBinding
could be false.I think
isValid
should only be true if all checks and validation have passed, so I made this PR to make it so that it is true. There is a test that tested the flow as it used to be (isValid: true
, but other fields havingfalse
value), so if it was on purpose I think we should maybe reconsider it, as it was kinda confusing.How I've handled it in the past is to create a nested validation object, to separate the overall check (isValid) from the individual checks: