Add bevy #32
berkusAnnotations
24 warnings
|
variable does not need to be mutable:
src/main.rs#L59
warning: variable does not need to be mutable
--> src/main.rs:59:5
|
59 | mut materials: ResMut<Assets<StandardMaterial>>,
| ----^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L58
warning: variable does not need to be mutable
--> src/main.rs:58:5
|
58 | mut images: ResMut<Assets<Image>>,
| ----^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L57
warning: variable does not need to be mutable
--> src/main.rs:57:5
|
57 | mut meshes: ResMut<Assets<Mesh>>,
| ----^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L55
warning: variable does not need to be mutable
--> src/main.rs:55:5
|
55 | mut commands: Commands,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `materials`:
src/main.rs#L59
warning: unused variable: `materials`
--> src/main.rs:59:9
|
59 | mut materials: ResMut<Assets<StandardMaterial>>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_materials`
|
|
unused variable: `images`:
src/main.rs#L58
warning: unused variable: `images`
--> src/main.rs:58:9
|
58 | mut images: ResMut<Assets<Image>>,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_images`
|
|
unused variable: `meshes`:
src/main.rs#L57
warning: unused variable: `meshes`
--> src/main.rs:57:9
|
57 | mut meshes: ResMut<Assets<Mesh>>,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_meshes`
|
|
unused variable: `commands`:
src/main.rs#L55
warning: unused variable: `commands`
--> src/main.rs:55:9
|
55 | mut commands: Commands,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commands`
|
= note: `#[warn(unused_variables)]` on by default
|
|
use of `expect` followed by a function call:
src/bin/convert_to_png.rs#L54
warning: use of `expect` followed by a function call
--> src/bin/convert_to_png.rs:54:14
|
54 | .expect(format!("Couldnt create png file {:?}", pngname).as_ref());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Couldnt create png file {:?}", pngname))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
|
|
unreachable statement:
src/main.rs#L92
warning: unreachable statement
--> src/main.rs:92:5
|
89 | return;
| ------ any code following this expression is unreachable
...
92 | / let models =
93 | | Model::load_many("assets/DecodedData/DATA/MODELS/NETCITYA.DAT").expect("Load models");
| |______________________________________________________________________________________________^ unreachable statement
|
= note: `#[warn(unreachable_code)]` on by default
|
|
use of `expect` followed by a function call:
src/bin/convert_to_png.rs#L43
warning: use of `expect` followed by a function call
--> src/bin/convert_to_png.rs:43:10
|
43 | .expect(format!("Couldnt open pix file {:?}", fname).as_ref());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Couldnt open pix file {:?}", fname))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
|
|
field assignment outside of initializer for an instance created with Default::default():
src/support/brender/model.rs#L146
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/model.rs:146:21
|
146 | model.name = model_chunk.identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::model::Model { name: model_chunk.identifier, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/model.rs:145:21
|
145 | let mut model = Model::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
|
|
called `map(..).flatten()` on `Iterator`:
src/support/brender/model.rs#L68
warning: called `map(..).flatten()` on `Iterator`
--> src/support/brender/model.rs:68:18
|
68 | .map(|f| [f.v1, f.v2, f.v3])
| __________________^
69 | | .flatten()
| |__________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|f| [f.v1, f.v2, f.v3])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
|
field assignment outside of initializer for an instance created with Default::default():
src/support/brender/material.rs#L173
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/material.rs:173:21
|
173 | mat.material = material;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::material::Material { material: material, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/material.rs:172:21
|
172 | let mut mat = Material::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
= note: `#[warn(clippy::field_reassign_with_default)]` on by default
|
|
`Box::new(_)` of default value:
src/support/brender/actor.rs#L106
warning: `Box::new(_)` of default value
--> src/support/brender/actor.rs:106:35
|
106 | actor.model = Box::new(Model::default()); //Models::find(model.identifier); // World::query<Model>?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::<Model>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `#[warn(clippy::box_default)]` on by default
|
|
returning the result of a `let` binding from a block:
src/support/brender/actor.rs#L190
warning: returning the result of a `let` binding from a block
--> src/support/brender/actor.rs:190:9
|
189 | let actor = stack.pop::<Actor>()?;
| ---------------------------------- unnecessary `let` binding
190 | actor
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
189 ~
190 ~ stack.pop::<Actor>()?
|
|
|
`Vec<T>` is already on the heap, the boxing is unnecessary:
src/support/brender/actor.rs#L66
warning: `Vec<T>` is already on the heap, the boxing is unnecessary
--> src/support/brender/actor.rs:66:15
|
66 | children: Vec<Box<Actor>>,
| ^^^^^^^^^^^^^^^ help: try: `Vec<Actor>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
= note: `#[warn(clippy::vec_box)]` on by default
|
|
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions/cache@v2, codecov/codecov-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/cache@v2, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|