Add bevy #35
berkusAnnotations
5 errors and 28 warnings
|
no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope:
src/bin/convert_to_png.rs#L66
error[E0599]: no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope
--> src/bin/convert_to_png.rs:66:30
|
66 | let palette = &PixelMap::load_many(String::from(
| ^^^^^^^^^ function or associated item not found in `PixelMap`
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
|
1 + use carma::support::brender::resource::LoadMany;
|
|
|
no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope:
src/bin/convert_to_png.rs#L42
error[E0599]: no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope
--> src/bin/convert_to_png.rs:42:26
|
42 | let pmap = PixelMap::load_many(fname.clone())
| ^^^^^^^^^ function or associated item not found in `PixelMap`
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
|
1 + use carma::support::brender::resource::LoadMany;
|
|
|
no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope:
src/bin/convert_to_png.rs#L35
error[E0599]: no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope
--> src/bin/convert_to_png.rs:35:30
|
35 | let palette = &PixelMap::load_many(String::from(
| ^^^^^^^^^ function or associated item not found in `PixelMap`
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
|
1 + use carma::support::brender::resource::LoadMany;
|
|
|
no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope:
src/bin/convert_to_png.rs#L20
error[E0599]: no function or associated item named `load_many` found for struct `carma::support::brender::pixelmap::PixelMap` in the current scope
--> src/bin/convert_to_png.rs:20:30
|
20 | let palette = &PixelMap::load_many(String::from(
| ^^^^^^^^^ function or associated item not found in `PixelMap`
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
|
1 + use carma::support::brender::resource::LoadMany;
|
|
|
Test
Process completed with exit code 1.
|
|
unused `std::result::Result` that must be used:
src/main.rs#L138
warning: unused `std::result::Result` that must be used
--> src/main.rs:138:5
|
138 | load_bunch::<Model>(&["assets/DecodedData/DATA/MODELS"], ".DAT", &mut models);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
help: use `let _ = ...` to ignore the resulting value
|
138 | let _ = load_bunch::<Model>(&["assets/DecodedData/DATA/MODELS"], ".DAT", &mut models);
| +++++++
|
|
unused `std::result::Result` that must be used:
src/main.rs#L118
warning: unused `std::result::Result` that must be used
--> src/main.rs:118:5
|
118 | / load_bunch::<PixelMap>(
119 | | &[
120 | | "assets/DecodedData/DATA/PIXELMAP",
121 | | "assets/DecodedData/DATA/64X48X8/PIXELMAP",
... |
125 | | &mut pixmaps,
126 | | );
| |_____^
|
= note: this `Result` may be an `Err` variant, which should be handled
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = load_bunch::<PixelMap>(
| +++++++
|
|
unused `std::result::Result` that must be used:
src/main.rs#L101
warning: unused `std::result::Result` that must be used
--> src/main.rs:101:5
|
101 | / load_bunch::<Material>(
102 | | &[
103 | | "assets/DecodedData/DATA/MATERIAL",
104 | | "assets/DecodedData/DATA/REG/MATERIAL",
... |
107 | | &mut mats,
108 | | );
| |_____^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
101 | let _ = load_bunch::<Material>(
| +++++++
|
|
length comparison to zero:
src/main.rs#L141
warning: length comparison to zero
--> src/main.rs:141:12
|
141 | if model.face_material_indices.len() > 0
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.face_material_indices.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
variable does not need to be mutable:
src/main.rs#L90
warning: variable does not need to be mutable
--> src/main.rs:90:5
|
90 | mut materials: ResMut<Assets<StandardMaterial>>,
| ----^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L89
warning: variable does not need to be mutable
--> src/main.rs:89:5
|
89 | mut images: ResMut<Assets<Image>>,
| ----^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L88
warning: variable does not need to be mutable
--> src/main.rs:88:5
|
88 | mut meshes: ResMut<Assets<Mesh>>,
| ----^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
src/main.rs#L86
warning: variable does not need to be mutable
--> src/main.rs:86:5
|
86 | mut commands: Commands,
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `materials`:
src/main.rs#L90
warning: unused variable: `materials`
--> src/main.rs:90:9
|
90 | mut materials: ResMut<Assets<StandardMaterial>>,
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_materials`
|
|
unused variable: `images`:
src/main.rs#L89
warning: unused variable: `images`
--> src/main.rs:89:9
|
89 | mut images: ResMut<Assets<Image>>,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_images`
|
|
unused variable: `meshes`:
src/main.rs#L88
warning: unused variable: `meshes`
--> src/main.rs:88:9
|
88 | mut meshes: ResMut<Assets<Mesh>>,
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_meshes`
|
|
unused variable: `commands`:
src/main.rs#L86
warning: unused variable: `commands`
--> src/main.rs:86:9
|
86 | mut commands: Commands,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_commands`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable statement:
src/main.rs#L216
warning: unreachable statement
--> src/main.rs:216:5
|
154 | return;
| ------ any code following this expression is unreachable
...
216 | / let debug_material = materials.add(StandardMaterial {
217 | | base_color_texture: Some(images.add(uv_debug_texture())),
218 | | ..default()
219 | | });
| |_______^ unreachable statement
|
= note: `#[warn(unreachable_code)]` on by default
|
|
`Box::new(_)` of default value:
src/support/brender/pixelmap.rs#L46
warning: `Box::new(_)` of default value
--> src/support/brender/pixelmap.rs:46:28
|
46 | let mut pixelmap = Box::new(PixelMap::default());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::<PixelMap>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
field assignment outside of initializer for an instance created with Default::default():
src/support/brender/model.rs#L169
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/model.rs:169:21
|
169 | model.identifier = model_chunk.identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::model::Model { identifier: model_chunk.identifier, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/model.rs:168:21
|
168 | let mut model = Model::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
|
|
called `map(..).flatten()` on `Iterator`:
src/support/brender/model.rs#L74
warning: called `map(..).flatten()` on `Iterator`
--> src/support/brender/model.rs:74:18
|
74 | .map(|f| [f.v1, f.v2, f.v3])
| __________________^
75 | | .flatten()
| |__________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|f| [f.v1, f.v2, f.v3])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
|
field assignment outside of initializer for an instance created with Default::default():
src/support/brender/material.rs#L180
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/material.rs:180:21
|
180 | mat.material = material;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::material::Material { material: material, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/material.rs:179:21
|
179 | let mut mat = Material::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
|
|
`Box::new(_)` of default value:
src/support/brender/actor.rs#L118
warning: `Box::new(_)` of default value
--> src/support/brender/actor.rs:118:35
|
118 | actor.model = Box::new(Model::default()); //Models::find(model.identifier); // World::query<Model>?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::<Model>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `#[warn(clippy::box_default)]` on by default
|
|
field assignment outside of initializer for an instance created with Default::default():
src/support/brender/actor.rs#L112
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/actor.rs:112:21
|
112 | act.actor = actor;
| ^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::actor::Actor { actor: actor, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/actor.rs:111:21
|
111 | let mut act = Actor::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
= note: `#[warn(clippy::field_reassign_with_default)]` on by default
|
|
returning the result of a `let` binding from a block:
src/support/brender/actor.rs#L202
warning: returning the result of a `let` binding from a block
--> src/support/brender/actor.rs:202:9
|
201 | let actor = stack.pop::<Actor>()?;
| ---------------------------------- unnecessary `let` binding
202 | actor
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
201 ~
202 ~ stack.pop::<Actor>()?
|
|
|
`Vec<T>` is already on the heap, the boxing is unnecessary:
src/support/brender/actor.rs#L68
warning: `Vec<T>` is already on the heap, the boxing is unnecessary
--> src/support/brender/actor.rs:68:15
|
68 | children: Vec<Box<Actor>>,
| ^^^^^^^^^^^^^^^ help: try: `Vec<Actor>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
= note: `#[warn(clippy::vec_box)]` on by default
|
|
unused imports: `BufReader`, `fs::File`, `resource::FromStream`:
src/support/texture.rs#L12
warning: unused imports: `BufReader`, `fs::File`, `resource::FromStream`
--> src/support/texture.rs:12:39
|
12 | brender::{pixelmap::PixelMap, resource::FromStream},
| ^^^^^^^^^^^^^^^^^^^^
...
18 | fs::File,
| ^^^^^^^^
19 | io::{BufReader, Write},
| ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|