Add bevy #29
Clippy Output
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check warning on line 52 in src/bin/convert_to_png.rs
github-actions / Clippy Output
use of `expect` followed by a function call
warning: use of `expect` followed by a function call
--> src/bin/convert_to_png.rs:52:14
|
52 | .expect(format!("Couldnt create png file {:?}", pngname).as_ref());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Couldnt create png file {:?}", pngname))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
Check warning on line 41 in src/bin/convert_to_png.rs
github-actions / Clippy Output
use of `expect` followed by a function call
warning: use of `expect` followed by a function call
--> src/bin/convert_to_png.rs:41:10
|
41 | .expect(format!("Couldnt open pix file {:?}", fname).as_ref());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Couldnt open pix file {:?}", fname))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
Check warning on line 141 in src/support/brender/model.rs
github-actions / Clippy Output
field assignment outside of initializer for an instance created with Default::default()
warning: field assignment outside of initializer for an instance created with Default::default()
--> src/support/brender/model.rs:141:21
|
141 | model.name = model_chunk.identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `support::brender::model::Model { name: model_chunk.identifier, ..Default::default() }` and removing relevant reassignments
--> src/support/brender/model.rs:140:21
|
140 | let mut model = Model::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
= note: `#[warn(clippy::field_reassign_with_default)]` on by default
Check warning on line 58 in src/support/brender/model.rs
github-actions / Clippy Output
called `map(..).flatten()` on `Iterator`
warning: called `map(..).flatten()` on `Iterator`
--> src/support/brender/model.rs:57:18
|
57 | .map(|f| [f.v1, f.v2, f.v3])
| __________________^
58 | | .flatten()
| |__________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|f| [f.v1, f.v2, f.v3])`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
Check warning on line 106 in src/support/brender/actor.rs
github-actions / Clippy Output
`Box::new(_)` of default value
warning: `Box::new(_)` of default value
--> src/support/brender/actor.rs:106:35
|
106 | actor.model = Box::new(Model::default()); //Models::find(model.identifier); // World::query<Model>?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::<Model>::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `#[warn(clippy::box_default)]` on by default
Check warning on line 190 in src/support/brender/actor.rs
github-actions / Clippy Output
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> src/support/brender/actor.rs:190:9
|
189 | let actor = stack.pop::<Actor>()?;
| ---------------------------------- unnecessary `let` binding
190 | actor
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
189 ~
190 ~ stack.pop::<Actor>()?
|
Check warning on line 66 in src/support/brender/actor.rs
github-actions / Clippy Output
`Vec<T>` is already on the heap, the boxing is unnecessary
warning: `Vec<T>` is already on the heap, the boxing is unnecessary
--> src/support/brender/actor.rs:66:15
|
66 | children: Vec<Box<Actor>>,
| ^^^^^^^^^^^^^^^ help: try: `Vec<Actor>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
= note: `#[warn(clippy::vec_box)]` on by default