Backport new-style 'PKG_PROG_PKG_CONFIG' macro from pkg-config 0.29.2. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zackw Do you agree with my workaround? |
besser82
force-pushed
the
topic/besser82/issue_198
branch
3 times, most recently
from
ae27956 to
500e2be
Compare
Since the definition of this macro has been changed to error-out if a new introduced second parameter is ommited and the pkg-conf executable is not found on the system, the configure script from the release tarballs will fail in certain minimal bootstrap environments, that do not include a pkg-config executable (or the provided version is too old). The backport of a compatibility is needed to be able to regenerate the build-system on older systems, which do not offer a variant of the macro definition with an optional second parameter. Fixes #198.
besser82
force-pushed
the
topic/besser82/issue_198
branch
from
500e2be to
85a7b3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #199 +/- ##
========================================
Coverage 90.12% 90.12%
========================================
Files 32 32
Lines 3627 3627
Branches 690 690
========================================
Hits 3269 3269
Misses 227 227
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the definition of this macro has been changed to error-out if a new introduced second parameter is ommited and the pkg-conf executable is not found on the system, the configure script from the release tarballs will fail in certain minimal bootstrap environments, that do not include a pkg-config executable (or the provided version is too old).
The backport of a compatibility is needed to be able to regenerate the build-system on older systems, which do not offer a variant of the macro definition with an optional second parameter.
Fixes #198.