-
Notifications
You must be signed in to change notification settings - Fork 3
Mhilliard/new rc ui and session transferrence #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seamuncle
wants to merge
42
commits into
master
Choose a base branch
from
mhilliard/new_rc_ui_and_session_transferrence
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rejigged firing reality checks so only 1 is open at a time. Updated call to /token with session_id (if it exists--though it likely doesn't).
…, provided boolean when checking credentials to determine the type of auth window to provide...login or register
…ys it's about 1.85 seconds)
…oposed in ms not s. Moved onPreRealityCheck back onto the main thread.
… now safe to clear up code that cares about older iOS
…ago--its now safe to clear up code that cares about older iOS" This reverts commit 9f068e1.
…es a GET query, and issue where logging out would maintain state from the last session.
…urned from manifest will already have this and adding a second one is problematic as it generates an unexpected list datatype
… colliding with session and client parameters on the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.