add hdzero h7 target #525
Open
add hdzero h7 target #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
requested changes
Aug 17, 2024
| #define DEFAULT_CURRENT_METER_SCALE 100 | ||
| #define BEEPER_INVERTED | ||
| #define FLASH_SPI_INSTANCE SPI2 | ||
| #define USE_SPI_GYRO |
There was a problem hiding this comment.
This is default
Suggested change
| #define USE_SPI_GYRO |
| #define FLASH_SPI_INSTANCE SPI2 | ||
| #define USE_SPI_GYRO | ||
| #define GYRO_1_SPI_INSTANCE SPI1 | ||
| #define GYRO_2_SPI_INSTANCE SPI1 |
There was a problem hiding this comment.
No return on EOF
Suggested change
| #define GYRO_2_SPI_INSTANCE SPI1 | |
| #define GYRO_2_SPI_INSTANCE SPI1 | |
ot0tot
reviewed
Aug 18, 2024
|
|
||
| #define USE_GYRO | ||
| #define USE_GYRO_SPI_MPU6000 | ||
| #define USE_GYRO_SPI_MPU6500 |
There was a problem hiding this comment.
Why include MPU6500?
Suggested change
| #define USE_GYRO_SPI_MPU6500 |
There was a problem hiding this comment.
I won't let them make a 6500 version!
ot0tot
reviewed
Aug 18, 2024
| TIMER_PIN_MAP( 4, LED_STRIP_PIN, 1, 0 ) \ | ||
| TIMER_PIN_MAP( 5, BEEPER_PIN, 1, 0 ) | ||
|
|
||
| #define SPI1_RX_DMA_OPT 7 |
There was a problem hiding this comment.
Not needed
Suggested change
| #define SPI1_RX_DMA_OPT 7 |
ot0tot
reviewed
Aug 18, 2024
| #define USE_GYRO_SPI_ICM42688P | ||
| #define USE_ACC | ||
| #define USE_ACC_SPI_MPU6000 | ||
| #define USE_ACC_SPI_MPU6500 |
There was a problem hiding this comment.
Suggested change
| #define USE_ACC_SPI_MPU6500 |
ot0tot
reviewed
Aug 18, 2024
Comment on lines
+80
to
+81
| TIMER_PIN_MAP( 2, MOTOR3_PIN, 2, 0 ) \ | ||
| TIMER_PIN_MAP( 3, MOTOR4_PIN, 2, 0 ) \ |
There was a problem hiding this comment.
Why are these on TIM8? If you move motors 3 and 4 to TIM3, only one TIMUP resource is required for burst DMA.
Suggested change
| TIMER_PIN_MAP( 2, MOTOR3_PIN, 2, 0 ) \ | |
| TIMER_PIN_MAP( 3, MOTOR4_PIN, 2, 0 ) \ | |
| TIMER_PIN_MAP( 2, MOTOR3_PIN, 1, 0 ) \ | |
| TIMER_PIN_MAP( 3, MOTOR4_PIN, 1, 0 ) \ |
ot0tot
reviewed
Aug 18, 2024
| #define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH | ||
| #define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_ADC | ||
| #define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC | ||
| #define DEFAULT_CURRENT_METER_SCALE 100 |
There was a problem hiding this comment.
Does this need to be set? Does this FC come with an ESC?
|
@freasy can you address the changes? or are you waiting for samples? |
Samples are on the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HDZERO H7 target