Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a11y tests in CI #19002

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

chore: add a11y tests in CI #19002

wants to merge 24 commits into from

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Apr 3, 2024

Ajout CI axe-core

Copy link

github-actions bot commented Apr 3, 2024

Rapport d'accessibilité axe-core pour 34b40a5 to https://beta.gouv.fr

Running axe-core 4.9.0 in chrome-headless

Testing https://beta.gouv.fr ... please wait, this may take a minute.

  Violation of "meta-viewport" with 1 occurrences!
    Ensures <meta name="viewport"> does not disable text scaling and zooming. Correct invalid elements at:
     - meta[name="viewport"]
    For details, see: https://dequeuniversity.com/rules/axe/4.9/meta-viewport

  Violation of "region" with 3 occurrences!
    Ensures all page content is contained by landmarks. Correct invalid elements at:
     - .fr-follow__newsletter > .fr-h5
     - .fr-text--sm
     - .fr-follow > .fr-container > .fr-grid-row > .fr-col-md-4.fr-col-12
    For details, see: https://dequeuniversity.com/rules/axe/4.9/region

4 Accessibility issues detected.
Testing complete of 1 pages

Please note that only 20% to 50% of all accessibility issues can automatically be detected. 
Manual testing is always required. For more information see:
https://dequeuniversity.com/curriculum/courses/testingmethods

@revolunet revolunet linked an issue Apr 5, 2024 that may be closed by this pull request
@revolunet revolunet changed the title Create a11ywatch.yml Add axe-core tests Apr 5, 2024
@revolunet revolunet changed the title Add axe-core tests chore: add a11y tests in CI Apr 15, 2024
@astranchet
Copy link
Contributor

Trop cool ! Quelques questions :

  • ça teste toutes les pages ?
  • à quel moment ? au moment d'une PR, avant de déployer ? ou en local ?
  • y a un display quelque part de l'évolution ? (question purement pas curiosité, c'était pas du tout dans la demande)

@revolunet
Copy link
Member Author

ça teste toutes les pages ?

avec axe-core on peut crawler une URL ou cibler certaines pages. (idéalement il ne faudrait cibler que les pages modifiées mais c'est pas évident à deviner.)

à quel moment ? au moment d'une PR, avant de déployer ? ou en local ?

Ca doit être à minima sur la PR via un environnement de "review" mais on peut régler comme on veut

y a un display quelque part de l'évolution ? (question purement pas curiosité, c'était pas du tout dans la demande)

non :)

Je testerai bien cette piste sinon : https://pragmaticpineapple.com/deploying-and-configuring-lightouse-ci-server/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajouter des tests automatiques d'accessibilité
2 participants