feat: Ajout du CTA + form autre projet sur le catalogue des projects #1565
+36
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced inline code for "OtherProject" functionality with a new, reusable `OtherProject` component. This simplifies the structure of `ResultProjectList.vue` and `CatalogProjects.vue`, reducing redundancy and improving maintainability. Unneeded logic and imports have been removed accordingly.
Refactored OtherProject component to accept a `form` prop via `defineProps`, providing better flexibility and reactivity. Updated ResultProjectList to pass `otherProjectForm` as a prop and added a watcher to reset the form state when `filteredProjects` changes.
dolemoine
requested review from
oumeimaelisbihani and
ttdm
and removed request for
oumeimaelisbihani
oumeimaelisbihani
approved these changes
Jan 22, 2025
| </Transition> | ||
| <div class="fr-container fr-m-0 fr-p-0 fr-pl-md-2v"> | ||
| <div class="fr-col-12 fr-col-offset-md-2 fr-col-md-10 fr-pl-md-2v fr-pr-md-6v"> | ||
| <OtherProject :form="otherProjectForm" /> |
There was a problem hiding this comment.
[praise] : propre la refacto!
Removed unused props from OtherProject and directly managed the form state locally for clarity and better independence. Added a watcher to reset the form state when the theme changes, ensuring a consistent behavior. Updated related components to reflect these adjustments and removed redundant logic.
yvalentin
approved these changes
Jan 27, 2025
| @@ -35,6 +35,9 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div class="fr-col-12 fr-col-justify--left fr-mt-3v fr-mb-10v"> | |||
There was a problem hiding this comment.
question: Je ne vois pas l'utilité de fr-col-justify--left, quand je l’enlève ça change rien. Mais je passe peut-être à coté de quelques choses ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Petite refacto pour ajouter le CTA + formulaire côté catalogue projet.
Test fonctionnel en local OK
app review: https://tee-preprod-pr1565.osc-fr1.scalingo.io/
close #1485