-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refacto(ui-landing): change psy space buttons / headings #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globalement je propose de mettre moins de gras et de couleurs :)
views/landing.ejs
Outdated
</p> | ||
<a class="rf-btn rf-btn--alt" href="<%= formUrl %>" target="_blank" rel="noopener noreferrer">Participer au dispositif</a> | ||
</h3> | ||
<a class="rf-btn rf-btn" href="<%= formUrl %>" target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pour les boutons primaires et secondaires, je propose de garder secondaire = transparent, parce que ca attire moins l'oeil (d'où l'aspect secondaire).
Pour les boutons primaires, je propose de garder le jaune comme partout ailleurs (si on repasse à bleu, on le fera pour tous les boutons primaires d'un coup)
Du coup ca fait :
FAQ : secondaire, transparent
Inscription et Declaration : primaire, jaune
views/landing.ejs
Outdated
@@ -113,16 +113,20 @@ | |||
Cette convention garantira le remboursement de l'ensemble des consultations que vous réaliserez dans le cadre de ce dispositif. | |||
</p> | |||
<% if (formUrl) { %> | |||
<p> | |||
<h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je pense qu'en mettant ce titre en gras, on perd complètement la visibilité du texte non-gras au dessus.
En p simple à mon avis c'est suffisant.
<h3> | |
<p> |
Pour le texte : "Vous voulez devenir psychologue partenaire du dispositif ?"
views/landing.ejs
Outdated
<p> | ||
<a class="rf-btn rf-btn--alt" href="/faq#psy">En savoir plus</a> | ||
<a class="rf-btn rf-btn--alt" href="/faq#psy"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a class="rf-btn rf-btn--alt" href="/faq#psy"> | |
<a class="rf-btn rf-btn--alt" href="/faq#je-suis-psychologue"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sur la FAQ c'est bien #psy
mais sur l'index l'ancre ajoutée est #je-suis-psychologue
Co-authored-by: Estelle Comment <estelle.comment@beta.gouv.fr>
Bonus: ajout d'une ancre HTML sur je suis un étudiant / psychologue
Avant
Après