Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAJ DSFR v1.13.0 #743

Merged
merged 2 commits into from
Feb 28, 2025
Merged

MAJ DSFR v1.13.0 #743

merged 2 commits into from
Feb 28, 2025

Conversation

alanzirek
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Anto59290 Anto59290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis étonné que ça passe la CI, chez moi il n'est plus possible d'ajouter un lieu.

(Sur Firefox, branche tirée et cache vidé. Sur main ça passe)

@alanzirek
Copy link
Collaborator Author

note:
En local sur Chrome, pas de problème de modale.
Pour la CI c'est dû au navigateur utilisé par Playwright.
Playwright utilise Chromium par défaut lors de l'exécution des tests, donc dans notre cas la CI est passée.

@alanzirek
Copy link
Collaborator Author

J'ai ajouté le fix sur un autre commit pour distinguer l'update du DSFR du fix

@alanzirek alanzirek merged commit 7221483 into main Feb 28, 2025
5 checks passed
@alanzirek alanzirek deleted the update-dsfr branch February 28, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants