-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capstone-Group-Project : Recipe app #43
Conversation
Milestone 1 : Set up project
Model for food
Milestone 2 : Create user and recipe models
Final touch on functionlaity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 @Gardimy, @beteland123,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ The PR title and description are good and professional.
✔️ No linter errors.
✔️ Descriptive readme file.
✔️ Beautiful UI👏
👏 The app works as expected.
Required Changes ♻️
Check the comments under the review.
- Kindly add more integration specs, we want to know how the app interacts in the browser, for example, if a button is clicked, how a user navigates from one page to another, etc.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Team 😃 🥳 🎉 🎈
Great Job 😄 👏 You've done it. Your project is complete! There is nothing else to say other than... it's time to merge it 👍🏻 ✅
To Highlight 💯
- Good implementation of the required changes ✔️
- Descriptive pr✔️
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this Final Capstone group Project, my coding partner and I Created a recipe app. This Recipe app keeps track of all our recipes, and ingredients. It allows us to save ingredients, keep track of what we have, create recipes, and generate a shopping list based on what we have and are missing from a recipe. Also, since sharing recipes is an essential part of cooking the app allows us to make them public so anyone can access them.
My coding partner and I addressed the following features and improvements:
We make sure to check the following below: