Update .gitignore and templates to resize donor and news images#1643
Closed
MyZeD wants to merge 2 commits intobevyengine:mainfrom
Closed
Update .gitignore and templates to resize donor and news images#1643MyZeD wants to merge 2 commits intobevyengine:mainfrom
MyZeD wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Webdev
A-Foundation
krunchington
approved these changes
Mar 8, 2025
Contributor
krunchington
left a comment
krunchington
left a comment
There was a problem hiding this comment.
Good use of the resize_image macro, and clamping to integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the size of the donor logos as they are too large. (See first screenshot)
The total file size of all images is 2.3 MB - in the new version the resizing only occurs in the rendered view to the same maximum height.
The result: 704kB (see 2. screenshot).
I also adjusted the height and width of the news images to the maximum rendering size.
I also wrote the donor_logos in the gitignore so that you can't upload them accidentally.