Update taffy requirement from 0.3.10 to 0.4.0 #12298
Conversation
Updates the requirements on [taffy](https://github.com/DioxusLabs/taffy) to permit the latest version. - [Release notes](https://github.com/DioxusLabs/taffy/releases) - [Changelog](https://github.com/DioxusLabs/taffy/blob/main/RELEASES.md) - [Commits](DioxusLabs/taffy@v0.3.10...v0.4.0) --- updated-dependencies: - dependency-name: taffy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
| .collect::<Vec<_>>(), | ||
| grid_row: style.grid_row.into(), | ||
| grid_column: style.grid_column.into(), | ||
| ..default() |
There was a problem hiding this comment.
There are some new overflow and scrollbar_width properties. Should they be replicated on bevy_ui::Style and if so, should that be done in this PR?
| user_root_node: taffy::tree::NodeId, | ||
| } | ||
|
|
||
| type UiTaffyTree = TaffyTree<Box<dyn Measure>>; |
There was a problem hiding this comment.
Now that the measurement/node context type is user-defined, should we use a enum with one variant for each of FixedMeasure, ImageMeasure... internal to bevy_ui plus a Box<dyn Measure> variant, to avoid doing dynamic dispatch for most use cases?
| available_space.height, | ||
| ) | ||
| }) | ||
| .unwrap_or(Vec2::ZERO); |
There was a problem hiding this comment.
Should layouting an empty leaf node with no size log a warning/error?
There was a problem hiding this comment.
I'd like a warn_once! for this.
There was a problem hiding this comment.
I'd say probably not. Such a node could get it's size from it's parent (e.g. by stretch alignment in a flexbox stack or to a grid cell)
Kanabenki
added
C-Dependencies
alice-i-cecile
added
the
M-Migration-Guide
|
Will do a proper review later, but note that I also have a PR for this: #10690 The only thing blocking that PR is:
This is required because Taffy 0.4 reserves space for padding/borders on leaf nodes but currently the content (text, image, etc) is still rendering at the top-left corner of the larger box rather than being offset by the border and padding widths. |
Closing in favor of this one since it seems a straight upgrade over the changes I did here. |
4 participants
Objective
Solution
needs_measuresince it has been removed.LayoutTreetrait with the corresponding traits it has been split into.MeasureFuncwith aBox<dyn<Measure>>as a node context, equivalent toMeasureFunc::Boxed.Changelog
Changed
0.4.0. If you are directly using taffy types re-exported frombevy_ui, you may need to change some import paths. (see the corresponding release notes)UiSurface::try_update_measuretakes aBox<dyn Measure>instead of the now removed taffyMeasureFunc.Migration Guide
UiSurface::try_update_measure, you should implement the bevy providedMeasuretrait on your measurement struct instead of using the removedMeasureFunc::Boxedwith the similar taffy providedMeasurabletrait.