fix examples color_grading and mobile after BackgroundColor changes #14033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
changed the title
mockersf
force-pushed
the
fix-color_grading-background-color-use
branch
from
e1339fa to
24f16dc
Compare
benfrankel
reviewed
Jun 26, 2024
| bottom: Val::Px(50.0), | ||
| ..default() | ||
| }, | ||
| BackgroundColor(Color::WHITE), |
Contributor
There was a problem hiding this comment.
Shouldn't this ButtonBundle have a background_color: Color::WHITE.into() now? Or is the background meant to be transparent?
Member
Author
There was a problem hiding this comment.
this is done by the button_handler system
benfrankel
approved these changes
Jun 26, 2024
alice-i-cecile
approved these changes
Jun 26, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
Thanks for catching these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
BackgroundColorandBorderColormore intuitive #14017 changed howUiImageandBackgroundColorworkcolor_grading, another in the mobile exampleSolution