Update taffy requirement from 0.7 to 0.8#20275
Closed
mnmaita wants to merge 4 commits intobevyengine:mainfrom
Closed
Update taffy requirement from 0.7 to 0.8#20275mnmaita wants to merge 4 commits intobevyengine:mainfrom
mnmaita wants to merge 4 commits intobevyengine:mainfrom
Conversation
Updates the requirements on [taffy](https://github.com/DioxusLabs/taffy) to permit the latest version. - [Release notes](https://github.com/DioxusLabs/taffy/releases) - [Changelog](https://github.com/DioxusLabs/taffy/blob/main/CHANGELOG.md) - [Commits](DioxusLabs/taffy@v0.7.0...v0.8.3) --- updated-dependencies: - dependency-name: taffy dependency-version: 0.8.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Member
Author
|
@nicoburns @ickshonpe @viridia hey folks! Can I get some pointers here on how to fix the remaining issues that need to be addressed for this update? These are, specifically, the Send and Sync impls for |
ickshonpe
added
C-Dependencies
Contributor
|
If you're not using calc, then you can unsafe impl Send/Sync on a newtype around Taffy. If you are using Calc, then this is safe if the Calc expr type you use is Send/Sync. (we want to solve this on the Taffy side bit this involves some non-trivial refactoring to introduce a generic rather than using *const ()) |
Member
Author
|
Superseded by #21672 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
taffy0.8 version.Testing