BrpRequest: remove jsonrpc field#23175
Open
SpecificProtagonist wants to merge 4 commits intobevyengine:mainfrom
Open
BrpRequest: remove jsonrpc field#23175SpecificProtagonist wants to merge 4 commits intobevyengine:mainfrom
SpecificProtagonist wants to merge 4 commits intobevyengine:mainfrom
Conversation
SpecificProtagonist
added
C-Usability
SpecificProtagonist
force-pushed
the
brp-jsonrpc-field
branch
from
bf9f593 to
9828f27
Compare
added 3 commits
March 1, 2026 11:26
alice-i-cecile
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
BrpRequestincludes a uselessjsonrpcfield that must always be set to "2.0". Remove it.This change could also be made to
BrpResponse, but that would be much more involved due to theserde(flatten)while also offering less benefit (as users need to create this struct less often).I've not added a migration guide because no advice is needed to migrate.
Testing
Run the
server+clientexample.