Add async hook support for GltfExtensionHandler#23198
Open
jiangheng90 wants to merge 2 commits intobevyengine:mainfrom
Open
Add async hook support for GltfExtensionHandler#23198jiangheng90 wants to merge 2 commits intobevyengine:mainfrom
jiangheng90 wants to merge 2 commits intobevyengine:mainfrom
Conversation
Contributor
Author
|
models are works fine on browser now |
jiangheng90
changed the title
kfc35
added
S-Needs-Review
alice-i-cecile
added
C-Feature
andriyDev
suggested changes
Mar 5, 2026
| unused, | ||
| reason = "default trait implementations do not use the arguments because they are no-ops" | ||
| )] | ||
| fn on_gltf_mesh( |
Contributor
There was a problem hiding this comment.
We should make all of these methods async, no?
Contributor
Author
There was a problem hiding this comment.
@andriyDev So far, I've only needed async for on_gltf_primitive. Given this, would it make sense to keep the other hooks synchronous for now? If other developers encounter use cases requiring async in the future, we can extend the API on demand at that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue #23026
this is an async hook support for on_gltf_primitive, so that makes it enable to support wasm
the detail implementation is at here and wasm website deploy here