Allow extract_mesh_materials to run in parallel with extract_meshes_for_gpu_building.#23211
Open
pcwalton wants to merge 1 commit intobevyengine:mainfrom
Open
Allow extract_mesh_materials to run in parallel with extract_meshes_for_gpu_building.#23211pcwalton wants to merge 1 commit intobevyengine:mainfrom
extract_mesh_materials to run in parallel with extract_meshes_for_gpu_building.#23211pcwalton wants to merge 1 commit intobevyengine:mainfrom
Conversation
`extract_meshes_for_gpu_building`. The ordering dates back to 56784de, before erased materials and whatnot. At this point, the systems seem to have no components or resources in common at all, so let's see if we can allow them to run in parallel. With all my other PRs landed, this will save about 4.12 ms per frame in `many_cubes` with millions of cubes, so this is a significant savings.
pcwalton
added
D-Modest
pcwalton
added
the
C-Performance
atlv24
approved these changes
Mar 4, 2026
tychedelia
approved these changes
Mar 4, 2026
Zeophlite
added
S-Ready-For-Final-Review
hukasu
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ordering dates back to 56784de, before erased materials and whatnot. At this point, the systems seem to have no components or resources in common at all, so let's see if we can allow them to run in parallel.
With all my other PRs landed, this will save about 4.12 ms per frame in
many_cubeswith millions of cubes, so this is a significant savings.