Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a nob build and uses it to add MSVC support.
Motivation:
I wanted to add an MSVC build for the B compiler. It would be convenient with my WIP MSVC codegen plugin so you can work on Windows without any GNU toolchain. Trying to do that in the Makefile was a huge mess.
Since we already require both a C compiler and nob.h to build the B compiler, it seemed like a natural choice to introduce a nob build that could eventually replace the Makefile.
Cons:
Pros:
make
-- one less moving part.Tested on:
TARGET_MSVC
TARGET_MINGW32
TARGET_POSIX
I know you've said on stream and in #283 that you'd prefer to extend bgen for the build. But as bgen still needs to be bootstrapped and the C files need to be compiled, I think switching to nob for that would still have tangible benefits.
What do you think?