removed sensor parameter in googlemaps js link, moved javascript incl…#20
Open
link82 wants to merge 1 commit intobeyondthestory:masterfrom
Open
removed sensor parameter in googlemaps js link, moved javascript incl…#20link82 wants to merge 1 commit intobeyondthestory:masterfrom
link82 wants to merge 1 commit intobeyondthestory:masterfrom
Conversation
…ude tag after int_map_field function definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed Google Maps deprecated the usage of "sensor" parameter inhibiting the initialization of the map if present, so i removed it:
https://developers.google.com/maps/documentation/javascript/error-messages#sensor-not-required
Sometimes I've received initialization errors apparently because init_map_field definition was invoked too soon by google maps script, before it has been defined so i moved gmap script include tag after it.
Thanks,
Davide