Skip to content

Conversation

fabianfiorotto
Copy link

Well ... this is my interception method. Whatever you think I should change just tell me.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 'intersect' instead of 'intercept'

@bfoz
Copy link
Owner

bfoz commented Dec 20, 2014

Thanks. We're off to a good start. I have a few comments...

  • Can you rebase this and squash it into a single commit?
  • Can we use fewer return statements in Line#intersection?
  • Likewise with 'self'
  • I'm trying to slowly migrate away from using 'assert_equals'-style tests in favor of 'must_equal'
  • Feel free to add blank lines between the example blocks. I'm not sure why I didn't do that originally.

Thanks for taking care of this. It's almost ready to go.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an elsif?

@bfoz bfoz force-pushed the master branch 2 times, most recently from d49c509 to b8ddf0e Compare April 19, 2016 00:40
@bfoz bfoz force-pushed the master branch 2 times, most recently from 4e17e62 to 492c9db Compare April 26, 2016 17:43
@kigster
Copy link

kigster commented May 28, 2017

Any reason this is not yet merged to master? Seems legit to me, and most certainly a useful feature.

I am debating using this library for re-implementation of my laser-cutter gem, since I had to build my own geometry objects, but I'd rather use something more feature rich and well tested.

@bfoz
Copy link
Owner

bfoz commented May 30, 2017

Because I completely forgot about it 😳
I'll try to get to it soon.

Nice gem. Why do I feel like I've heard about it somewhere? Hackaday?
Let me know if you need anything for the integration.

@bfoz bfoz force-pushed the main branch 3 times, most recently from b6f172d to 0a3ca21 Compare March 21, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants