feat: svr steward #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻️ Forge Gas Snapshots🔕 Unchanged
|
Forge Build Sizes🔕 Unchanged
|
kyzia551
reviewed
Feb 26, 2025
TepNik
reviewed
Feb 26, 2025
| } | ||
|
|
||
| /// @inheritdoc ISvrOracleSteward | ||
| function disableSvrOracle(address asset) external onlyGuardian { |
There was a problem hiding this comment.
Just an idea to change the onlyGuardian modifier to the onlyOwnerOrGuardian.
sakulstra
commented
Mar 5, 2025
🌈 Test ResultsNo files changed, compilation skipped
Ran 12 tests for tests/risk/SvrOracleSteward.t.sol:SvrOracleStewardBaseTest
[PASS] test_activateSvrOracle_shouldRevertIfNotConfig() (gas: 17929)
[PASS] test_activateSvroracle() (gas: 83682)
[PASS] test_activateSvroracle_shouldRevertIfDeviationExceeded() (gas: 77003)
[PASS] test_activateSvroracle_shouldRevertIfOracleChangedOutside() (gas: 51143)
[PASS] test_configureOracle() (gas: 66255)
[PASS] test_configureOracle_shouldRevertWithWrongOracle() (gas: 108723)
[PASS] test_disableSvrOracle() (gas: 93648)
[PASS] test_disableSvrOracle_shouldRevertIfNotConfig() (gas: 28725)
[PASS] test_disableSvrOracle_shouldRevertifOutsideOracleChange() (gas: 101104)
[PASS] test_ifNoGuardian_activateSvrOracle_shouldRevert() (gas: 13422)
[PASS] test_ifNoGuardian_disableSvrOracle_shouldRevert() (gas: 11155)
[PASS] test_ifNoOwner_configureOracle_shouldRevert() (gas: 11270)
Suite result: ok. 12 passed; 0 failed; 0 skipped; finished in 5.17s (4.86s CPU time)
Ran 28 tests for tests/gas/maintenance/ClinicSteward.gas.t.sol:ClinicStewardGasTest
[PASS] test_batchLiquidate_five_users() (gas: 1790961)
[PASS] test_batchLiquidate_four_users() (gas: 1466277)
[PASS] test_batchLiquidate_one_user() (gas: 700611)
[PASS] test_batchLiquidate_six_users() (gas: 2009858)
[PASS] test_batchLiquidate_three_users() (gas: 1247423)
[PASS] test_batchLiquidate_two_users() (gas: 1028507)
[PASS] test_batchLiquidate_zero_users() (gas: 256311)
[PASS] test_batchRepayBadDebt_five_users() (gas: 631701)
[PASS] test_batchRepayBadDebt_four_users() (gas: 568873)
[PASS] test_batchRepayBadDebt_one_user() (gas: 383617)
[PASS] test_batchRepayBadDebt_six_users() (gas: 694463)
[PASS] test_batchRepayBadDebt_three_users() (gas: 506048)
[PASS] test_batchRepayBadDebt_two_users() (gas: 443290)
[PASS] test_batchRepayBadDebt_zero_users() (gas: 236342)
[PASS] test_getBadDebtAmount_five_users() (gas: 108457)
[PASS] test_getBadDebtAmount_four_users() (gas: 94411)
[PASS] test_getBadDebtAmount_one_user() (gas: 52255)
[PASS] test_getBadDebtAmount_six_users() (gas: 122568)
[PASS] test_getBadDebtAmount_three_users() (gas: 80389)
[PASS] test_getBadDebtAmount_two_users() (gas: 66363)
[PASS] test_getBadDebtAmount_zero_users() (gas: 23218)
[PASS] test_getDebtAmount_five_users() (gas: 89846)
[PASS] test_getDebtAmount_four_users() (gas: 79506)
[PASS] test_getDebtAmount_one_user() (gas: 48559)
[PASS] test_getDebtAmount_six_users() (gas: 100140)
[PASS] test_getDebtAmount_three_users() (gas: 69169)
[PASS] test_getDebtAmount_two_users() (gas: 66333)
[PASS] test_getDebtAmount_zero_users() (gas: 23143)
Suite result: ok. 28 passed; 0 failed; 0 skipped; finished in 5.59s (101.18ms CPU time)
Ran 16 tests for tests/maintenance/ClinicSteward.t.sol:ClinicStewardTest
[PASS] test_batchLiquidate() (gas: 1974454)
[PASS] test_batchLiquidateUseAToken() (gas: 2155594)
[PASS] test_batchRepayBadDebt() (gas: 718983)
[PASS] test_batchRepayBadDebtUseAToken() (gas: 603389)
[PASS] test_getBadDebtAmount() (gas: 142263)
[PASS] test_getDebtAmount() (gas: 119888)
[PASS] test_maxRescue() (gas: 185526)
[PASS] test_rescueEth() (gas: 28299)
[PASS] test_rescueToken() (gas: 198558)
[PASS] test_reverts_batchLiquidate_caller_not_cleaner(address) (runs: 256, μ: 36728, ~: 36728)
[PASS] test_reverts_batchLiquidate_exceeded_pull_limit() (gas: 3912325)
[PASS] test_reverts_batchRepayBadDebt_caller_not_cleaner(address) (runs: 256, μ: 34579, ~: 34579)
[PASS] test_reverts_batchRepayBadDebt_exceeded_pull_limit() (gas: 2283956)
[PASS] test_reverts_setAvailableBudget_caller_not_admin(address) (runs: 256, μ: 15391, ~: 15391)
[PASS] test_setAvailableBudget() (gas: 24847)
[PASS] test_userHasSomeCollateral_returns_zero() (gas: 66453)
Suite result: ok. 16 passed; 0 failed; 0 skipped; finished in 8.25s (5.89s CPU time)
Ran 3 test suites in 8.25s (19.01s CPU time): 56 tests passed, 0 failed, 0 skipped (56 total tests) |
🔮 Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: