Merge pull request #39 from bgokden/refactor

Avoid long running connection to service node
bgokden · Jul 2, 2021 · 4da189c · 4da189c
2 parents 31c5041 + f1fd3ab
commit 4da189c
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/node/nodeservice.go b/node/nodeservice.go
@@ -229,6 +229,9 @@ func (n *Node) SendJoinRequest(id string) error {
 			n.KnownIds = append(n.KnownIds, feedbackID)
 		}
 	}
+	conn.Close() // this connection should be closed time to time
+	// It is observed that it can cause a split brain due to two nodes
+	// sync to each other and never break connection
 	return nil
 }