Merge pull request galaxyproject#16553 from jdavcs/dev_formdef_bugfix

Rename to_dict to populate in FormDefintion to fix bug

lib/galaxy/model/__init__.py

@@ -9147,7 +9147,7 @@ class types(str, Enum):
     dict_collection_visible_keys = ["id", "name"]
     dict_element_visible_keys = ["id", "name", "desc", "form_definition_current_id", "fields", "layout"]
 
-    def to_dict(self, user=None, values=None, security=None):
+    def populate(self, user=None, values=None, security=None):
         values = values or {}
         form_def = {"id": security.encode_id(self.id) if security else self.id, "name": self.name, "inputs": []}
         for field in self.fields:

lib/galaxy/webapps/galaxy/api/users.py

@@ -800,7 +800,7 @@ def get_information(self, trans, id, **kwd):
                     values = None
                     if info_form_id == trans.security.encode_id(f.id) and user.values:
                         values = user.values.content
-                    info_form = f.to_dict(user=user, values=values, security=trans.security)
+                    info_form = f.populate(user=user, values=values, security=trans.security)
                     info_field["test_param"]["data"].append({"label": info_form["name"], "value": info_form["id"]})
                     info_field["cases"].append({"value": info_form["id"], "inputs": info_form["inputs"]})
                 inputs.append(info_field)