Skip to content

Commit

Permalink
fix connector_destroy_callout selector
Browse files Browse the repository at this point in the history
  • Loading branch information
ElectronicBlueberry committed Aug 11, 2023
1 parent 89d83b9 commit fd20f7b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion client/src/utils/navigation/navigation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,7 @@ workflow_editor:
output_terminal: "${_} [output-name='${name}']"
input_terminal: "${_} [input-name='${name}']"
input_mapping_icon: "${_} [input-name='${name}'].mapped-over"
connector_destroy_callout: "${_} [input-name='${name}'] + .delete-terminal-button"
workflow_output_toggle: "${_} [data-output-name='${name}'] .callout-terminal "
workflow_output_toggle_active: "${_} [data-output-name='${name}'] .mark-terminal-active"
selectors:
Expand Down Expand Up @@ -770,7 +771,6 @@ workflow_editor:
tool_version_button: ".tool-versions"
connector_for: "#connection-${sink_id}-${source_id}"
connector_invalid_for: "#connection-${sink_id}-${source_id} .connection.invalid"
connector_destroy_callout: '.delete-terminal-button'
save_button: '.editor-button-save'
save_workflow_confirmation_button: '#save-workflow-confirmation .btn-primary'
state_modal_body: '.state-upgrade-modal'
Expand Down
8 changes: 4 additions & 4 deletions lib/galaxy_test/selenium/test_workflow_editor.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def test_non_data_connections(self):
tool_node = editor.node._(label="tool_exec")
tool_input = tool_node.input_terminal(name="inttest")
self.hover_over(tool_input.wait_for_visible())
editor.connector_destroy_callout.wait_for_and_click()
tool_node.connector_destroy_callout(name="inttest").wait_for_and_click()
self.assert_not_connected("input_int#output", "tool_exec#inttest")
self.screenshot("workflow_editor_parameter_connection_destroyed")

Expand Down Expand Up @@ -352,9 +352,9 @@ def test_existing_connections(self):
cat_node = editor.node._(label="first_cat")
cat_input = cat_node.input_terminal(name="input1")
self.hover_over(cat_input.wait_for_visible())
editor.connector_destroy_callout.wait_for_visible()
cat_node.connector_destroy_callout(name="input1").wait_for_visible()
self.screenshot("workflow_editor_connection_callout")
editor.connector_destroy_callout.wait_for_and_click()
cat_node.connector_destroy_callout(name="input1").wait_for_and_click()
self.assert_not_connected("input1#output", "first_cat#input1")
self.screenshot("workflow_editor_connection_destroyed")

Expand Down Expand Up @@ -1181,7 +1181,7 @@ def workflow_editor_destroy_connection(self, sink):
sink_node = editor.node._(label=sink_node_label)
sink_input = sink_node.input_terminal(name=sink_input_name).wait_for_visible()
self.hover_over(sink_input)
editor.connector_destroy_callout.wait_for_and_click()
sink_node.connector_destroy_callout(name=sink_input_name).wait_for_and_click()

def assert_input_mapped(self, sink):
editor = self.components.workflow_editor
Expand Down

0 comments on commit fd20f7b

Please sign in to comment.