Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log option required for multiqc for Sambamba markdup #1575

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

SaimMomin12
Copy link
Contributor

This PR adds log option required for MultiQC plugin

@bgruening
Copy link
Owner

Should the log file be optional?

@SaimMomin12
Copy link
Contributor Author

Should the log file be optional?

Sure, we can also make it optional.

@SaimMomin12
Copy link
Contributor Author

ping @bgruening

@bgruening bgruening enabled auto-merge (squash) February 10, 2025 15:09
@bgruening
Copy link
Owner

We needed a build bump here.

auto-merge was automatically disabled February 10, 2025 15:28

Head branch was pushed to by a user without write access

@SaimMomin12
Copy link
Contributor Author

@bgruening Sorry, there was some issue in the last CI check. Auto-merge required again! Thanks.

@bgruening bgruening merged commit 99bb4ed into bgruening:master Feb 10, 2025
14 checks passed
@bgruening
Copy link
Owner

Thanks!

@bgruening bgruening deleted the add_sambamba_log branch February 10, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants