Add :config-profile CLI option for resource-based config overlays #143

bhauman · 2026-01-02T18:12:07Z

Summary

Add :config-profile CLI option to load built-in config profiles from classpath resources
Profiles are deep-merged on top of base config with highest precedence
Include cli-assist profile with clojure_edit_agent, list_nrepl_ports, clojure_eval tools enabled and write-file-guard disabled

Usage

# Apply cli-assist profile
clojure -X:mcp :config-profile :cli-assist

# Combine with custom config file
clojure -X:mcp :config-file '"/tmp/custom.edn"' :config-profile :cli-assist

Merge precedence (highest to lowest)

:config-profile overlay (if provided)
:config-file or project config (.clojure-mcp/config.edn)
home config (~/.clojure-mcp/config.edn)

Test plan

Unit tests for load-config-profile (keyword/string/symbol, missing profile, nil)
Unit tests for apply-config-profile (merge behavior, nil profile, deep merge)
Unit tests for cli-assist profile contents
All existing tests pass (281 tests, 0 failures)

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Added --config-profile CLI option to apply predefined configuration profiles that customize tooling behavior
- Configuration profiles overlay settings on top of base configuration for flexible customization
Tests
- Added comprehensive test coverage for profile loading and merging functionality

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Allow users to apply built-in config profiles from classpath resources via CLI argument. Profiles are deep-merged on top of the base config with highest precedence. Usage: clojure -X:mcp :config-profile :cli-assist Includes cli-assist profile with clojure_edit_agent, list_nrepl_ports, clojure_eval tools enabled and write-file-guard disabled. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2026-01-02T18:12:15Z

📝 Walkthrough

Walkthrough

A configuration profile system is introduced, enabling overlay of EDN-based configuration profiles onto base configurations. The system includes a new CLI option, config loading/merging functions, and threaded profile parameter through nREPL initialization.

Changes

Cohort / File(s)	Summary
Configuration Infrastructure `resources/clojure_mcp/configs/cli-assist.edn`, `src/clojure_mcp/config.clj`	New EDN config profile enabling CLJ tooling features (`clojure_edit_agent`, `list_nrepl_ports`, `clojure_eval`) and disabling write-file guard. Config module exposes `deep-merge` (made public), adds `load-config-profile` and `apply-config-profile` functions, and extends `load-config` to support optional profile overlay with updated merge precedence.
Core Initialization `src/clojure_mcp/core.clj`	Threads `config-profile` parameter through configuration loading pipeline: `load-config-handling-validation-errors` and `fetch-config` now accept optional profile; `create-and-start-nrepl-connection` propagates profile through initial-config; adds `::config-profile` spec and updates `::nrepl-args` to include profile in optional keys.
CLI Interface `src/clojure_mcp/prompt_cli.clj`	Adds `--config-profile PROFILE` CLI option with keyword parsing (handles leading colon); `run-prompt` destructures config-profile and passes it through config loading.
Test Suite `test/clojure_mcp/config/profile_test.clj`	New test module covering profile loading (keyword/string/symbol inputs, missing/nil handling), profile application and override behavior, deep-merge nesting, and cli-assist profile contents validation.

Sequence Diagram

sequenceDiagram
    participant CLI as CLI Parser
    participant Core as Core Init
    participant Config as Config Module
    participant Files as Config Files
    participant nREPL as nREPL Client

    CLI->>CLI: Parse --config-profile option
    CLI->>Core: run-prompt with config-profile
    Core->>Config: load-config-handling-validation-errors(file, dir, profile)
    Config->>Files: Load home config
    Files-->>Config: home config
    Config->>Files: Load project config
    Files-->>Config: project config
    Config->>Config: Merge home + project
    Config->>Config: load-config-profile(profile)
    Files-->>Config: profile config
    Config->>Config: apply-config-profile (overlay)
    Config-->>Core: Final merged config
    Core->>nREPL: Create connection with final config
    nREPL-->>Core: nREPL client initialized

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

PR #104: Modifies config.clj load-config and merge behavior with validation schema—overlaps with profile overlay and merge precedence changes.
PR #99: Updates config.clj merging logic including deep-merge exposure—directly related to profile merging infrastructure.

Poem

🐰 A config profile hops in, bringing tools and tweaks,
Overlaying gently on the base that's sought for weeks,
Merge paths deep and true, from home to proj to profile's grace,
CLI flags now parse the way, threading through the place! ✨

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a :config-profile CLI option that loads resource-based configuration overlays, which is the primary feature introduced across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

resources/clojure_mcp/configs/cli-assist.edn (1)
1-6: LGTM — consider adding a brief comment.

The profile structure is correct and aligns with the PR objectives. The tool names use the expected underscore convention for MCP tools.

Consider adding a comment at the top explaining the profile's purpose for future maintainers:
💡 Optional: Add documentation comment
+;; CLI-assist profile: Enables tools for command-line agent workflows.
+;; Disables write-file-guard to allow unrestricted file writes.
 {:enable-tools
  [:clojure_edit_agent
   :list_nrepl_ports
   :clojure_eval]

  :write-file-guard false}
src/clojure_mcp/prompt_cli.clj (1)
40-44: Consider extracting the keyword parse function to reduce duplication.

The parse-fn logic for converting strings to keywords (lines 41-44) is identical to the model option's parse-fn (lines 29-32). Consider extracting a shared helper.
💡 Optional refactor
;; Define once near the top of cli-options
(defn- parse-keyword [s]
  (if (str/starts-with? s ":")
    (keyword (subs s 1))
    (keyword s)))

;; Then use in both places:
;; :parse-fn parse-keyword

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5810ff6 and df798d4.

📒 Files selected for processing (5)

resources/clojure_mcp/configs/cli-assist.edn
src/clojure_mcp/config.clj
src/clojure_mcp/core.clj
src/clojure_mcp/prompt_cli.clj
test/clojure_mcp/config/profile_test.clj

🧰 Additional context used

📓 Path-based instructions (2)

**/*.clj

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.clj: Use :require with ns aliases in Clojure imports (e.g., [clojure.string :as string])
Use kebab-case for variable and function names in Clojure
End Clojure predicate functions with ? (e.g., is-top-level-form?)
Use try/catch with specific exception handling in Clojure; use atom for tracking errors
Use 2-space indentation in Clojure code and maintain whitespace in edited forms
Align Clojure namespaces with directory structure (e.g., clojure-mcp.repl-tools)
Include clear tool :description in MCP tools for LLM guidance
Validate inputs and provide helpful error messages in MCP tool implementations
Return structured data with both result and error status in MCP tool responses
Maintain atom-based state for consistent service access in MCP tool implementations

Files:

test/clojure_mcp/config/profile_test.clj
src/clojure_mcp/config.clj
src/clojure_mcp/prompt_cli.clj
src/clojure_mcp/core.clj

**/*test*.clj

📄 CodeRabbit inference engine (CLAUDE.md)

Use deftest with descriptive names in Clojure tests; use testing for subsections and is for assertions

Files:

test/clojure_mcp/config/profile_test.clj

🧠 Learnings (9)

📓 Common learnings

Learnt from: CR
Repo: bhauman/clojure-mcp PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-02T16:18:02.394Z
Learning: Applies to **/*.clj : Include clear tool `:description` in MCP tools for LLM guidance

Learnt from: CR
Repo: bhauman/clojure-mcp PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-02T16:18:02.394Z
Learning: Applies to **/*.clj : Align Clojure namespaces with directory structure (e.g., `clojure-mcp.repl-tools`)