Skip to content

UI/improvements#26

Open
shubhdhebar wants to merge 2 commits intobhavya-tech:mainfrom
shubhdhebar:ui/improvements
Open

UI/improvements#26
shubhdhebar wants to merge 2 commits intobhavya-tech:mainfrom
shubhdhebar:ui/improvements

Conversation

@shubhdhebar
Copy link

UI Improvement:

double maxX = 0.0;
double maxY = 0.0;

final double singleUnit = 50; //Value can be adjusted as per desired sensitivity.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be moved to constants.dart.
Also should we use paneEventMultiplier and paneTimestampMultiplier for dx and dy?

void navigateViaKeyboard(KeyEvent event) {
double dy = 0;
double dx = 0;
if (event.physicalKey == PhysicalKeyboardKey.arrowLeft || event.physicalKey == PhysicalKeyboardKey.keyA) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make a const Map <PhysicalKeyboardKey: Offset> at the top level for brevity and performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants