Update CI #707
Update CI #707
Conversation
crates.io doesn't support this and they're outdated anyway.
Use `actions/checkout@v3` to remove a warning about old versions of node. Use `dtolay/rust-toolchain` instead of `actions-rs/toolchain` as it is maintained (and `actions-rs` actions are not). This also resolves a number of warnings about deprecated functionality within the GitHub Actions UI. Update one usage of `Swatimem/rust-cache` to v2. The other already was updated. Use `cargo` directly instead of using `actions-rs/cargo` as that action is also unmaintained.
waywardmonkeys
force-pushed
the
update-ci
branch
from
b728c41
to
e784c4b
Compare
|
There's a chance that with the old action, it wasn't actually testing with the MSRV. I can reproduce this failure for 1.64 for |
Let's bump MSRV to 1.66? |
|
I'll come back to this and dig more. It bothers me. This feature should be in Rust 1.63, so 1.64 shouldn't be an issue. It will be a couple of days though. |
|
Looks like it is this: rust-lang/rust#103306 which was fixed in 1.66 ... (it is 2:40am here and I should be asleep). |
This results in an error when building with 1.64 despite `AsFd` having been added in 1.63. It was fixed in 1.66: rust-lang/rust#103306
|
@lemmih It seems a shame to update the MSRV so soon and for a fringe / experimental platform. Maybe it is okay to just skip this test except for on stable toolchain for now? I've added a commit that does that in case you approve. |
No description provided.